Skip to content

TYP: update to mypy-0.910 #42206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Conversation

simonjayhawkins
Copy link
Member

No description provided.

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Jun 24, 2021
@simonjayhawkins
Copy link
Member Author

we will be able to start using TypeGuard https://docs.python.org/3.10/library/typing.html#typing.TypeGuard (imported from typing_extensions inside a TYPE_CHECKING)

Unfortunately, we can't use overloads or preserve types and most of our casts will still be required as the narrowed type will be wider in most cases!

Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback added this to the 1.4 milestone Jun 25, 2021
@jreback jreback merged commit 90f8be0 into pandas-dev:master Jun 25, 2021
@jreback
Copy link
Contributor

jreback commented Jun 25, 2021

nice!

@simonjayhawkins simonjayhawkins deleted the mypy-0.910 branch June 25, 2021 08:14
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants