DOC: Correct docstring for Series.apply #42193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
approved these changes
Jun 23, 2021
|
@MarcoGorelli The docstring was incorrect before #39941 - I think we should value a correct docstring here even if it's not exactly clear what the behavior is. To be sure, while I find this unclear, my opinion is that it's the implementation (changing behavior based on whether an EA has certain private method or not) that is undesirable, but I don't see a clear way to fix. |
|
thanks @rhshadrach |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jun 24, 2021
|
@meeseeksdev backport 1.3.x |
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Jun 24, 2021
Co-authored-by: Richard Shadrach <[email protected]>
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #39941 (comment) and the conversation preceding it. While I don't find @MarcoGorelli's suggestion as implemented here very clear, it at least makes it correct and I don't see a better way.