Skip to content

DOC: share swaplevel docstring between DataFrame and Series (#42120) #42148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2021
Merged

DOC: share swaplevel docstring between DataFrame and Series (#42120) #42148

merged 3 commits into from
Jun 26, 2021

Conversation

neinkeinkaffee
Copy link
Contributor

@neinkeinkaffee neinkeinkaffee commented Jun 20, 2021 •
edited
Loading

This commit

  • adds examples to the Series.swaplevel docstring
  • reuses the same template in Series.swaplevel and DataFrame.swaplevel docstrings

@MarcoGorelli MarcoGorelli self-requested a review June 20, 2021 21:07
@jreback jreback added this to the 1.3 milestone Jun 25, 2021
@jreback
Copy link
Contributor

jreback commented Jun 25, 2021

looks fine. @MarcoGorelli can you have a look

MarcoGorelli
MarcoGorelli approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I built this locally and it looks good, nice to have an example for the Series case now and for the two docstrings to be more aligned!

@MarcoGorelli MarcoGorelli merged commit fa6b96e into pandas-dev:master Jun 26, 2021
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 26, 2021
@neinkeinkaffee @meeseeksmachine
Backport PR pandas-dev#42148: DOC: share swaplevel docstring between …
01b6609 
…DataFrame and Series (pandas-dev#42120)
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 26, 2021
Merged
@sthagen sthagen mentioned this pull request Jun 26, 2021
Merged
4 tasks
simonjayhawkins pushed a commit that referenced this pull request Jun 27, 2021
@meeseeksmachine @neinkeinkaffee
Backport PR #42148: DOC: share swaplevel docstring between DataFrame …
5d2a135 
…and Series (#42120) (#42257)

Co-authored-by: Gesa Stupperich <[email protected]>
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@neinkeinkaffee @JulianWgs
DOC: share swaplevel docstring between DataFrame and Series (pandas-d…
4aeb113 
…ev#42120) (pandas-dev#42148)

* DOC: Share swaplevel docstring between Series and DataFrame (pandas-dev#42120)

* DOC: Add dtype to example output (pandas-dev#42120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

DOC share docs between Series.swaplevel and DataFrame.swaplevel
4 participants
@neinkeinkaffee @jreback @MarcoGorelli @simonjayhawkins