Skip to content

DOC: Substitute example in DataFrame.to_markdown docstring (#42126) #42144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2021

Conversation

neinkeinkaffee
Copy link
Contributor

@neinkeinkaffee neinkeinkaffee commented Jun 20, 2021

@MarcoGorelli
Copy link
Member

Nice, thanks @neinkeinkaffee ! Did you try building these pages locally to check that they show up fine? If so, could you post a screenshot?

see here for how to build the docs locally, you'll probably want to use the --single option with pandas.DataFrame.to_markdown

@neinkeinkaffee
Copy link
Contributor Author

Sure! This is how they look like:

Screenshot 2021-06-20 at 15 27 52

Screenshot 2021-06-20 at 15 28 12

@MarcoGorelli
Copy link
Member

Thanks - From the first screenshot you posted (DataFrame.to_markdown), it looks like the Series example is still the one being substituted into the docstring 🤔

@neinkeinkaffee
Copy link
Contributor Author

OMG, you're right, weird, I could swear it was alright when I checked earlier! Will check what happened there

@neinkeinkaffee
Copy link
Contributor Author

neinkeinkaffee commented Jun 20, 2021

Here it is one more time:

Screenshot 2021-06-20 at 17 20 14

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks (perhaps you hadn't done python make.py clean before starting?)

Looks good to me pending green

@attack68
Copy link
Contributor

attack68 commented Jun 21, 2021

we could also add to_markdown to user_guide/io/rst. It recently had some output methods added, but I didn't even know this one existed.

@MarcoGorelli
Copy link
Member

Good idea - @neinkeinkaffee if you wanted to do that (in a separate PR) it'd be welcome, else we can open it as an issue for others to take

CI failures here are probably unrelated, if you fetch and merge upstream/master once CI is fixed they'll probably be fine

@neinkeinkaffee
Copy link
Contributor Author

@MarcoGorelli Sure, I'll add it to userguide/io.rst and submit a separate PR for that.

Regarding the failing CI check of this one, do you mean I should just merge my branch with master again and that might fix it?

@MarcoGorelli
Copy link
Member

Yeah, that's right - latest PRs seem to be mostly green, so if you fetch and merge upstream/master now that might be enough

@neinkeinkaffee neinkeinkaffee force-pushed the 42126-docstring-params branch from 03b863b to c2d61c3 Compare June 21, 2021 19:00
@neinkeinkaffee
Copy link
Contributor Author

neinkeinkaffee commented Jun 21, 2021

Updated with the most recent commits from master, hopefully that'll make the checks go green. I'll work on updating the io.rst on a separate branch.

@neinkeinkaffee
Copy link
Contributor Author

Actually, having a second look at io.rst I see that the documentation for each of the read and write methods is quite extensive there, containing lots of tips and tricks. Not sure if I can come up with something like that for to_markdown on the spot, it looks like a bigger project to be honest :)

@MarcoGorelli
Copy link
Member

No worries, I can open it up as an issue and someone else will take it! Thanks for your help on this one!

@lithomas1 lithomas1 added the Docs label Jun 21, 2021
@MarcoGorelli
Copy link
Member

@simonjayhawkins I've seen some recent docs PRs being tagged as 1.3, is that an OK milestone for this one too?

@MarcoGorelli MarcoGorelli added this to the 1.4 milestone Jul 2, 2021
@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli merged commit 844b388 into pandas-dev:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC DataFrame.to_markdown examples don't get substituted
4 participants