-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Substitute example in DataFrame.to_markdown docstring (#42126) #42144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Substitute example in DataFrame.to_markdown docstring (#42126) #42144
Conversation
Nice, thanks @neinkeinkaffee ! Did you try building these pages locally to check that they show up fine? If so, could you post a screenshot? see here for how to build the docs locally, you'll probably want to use the |
Thanks - From the first screenshot you posted (DataFrame.to_markdown), it looks like the Series example is still the one being substituted into the docstring 🤔 |
OMG, you're right, weird, I could swear it was alright when I checked earlier! Will check what happened there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks (perhaps you hadn't done python make.py clean
before starting?)
Looks good to me pending green
we could also add |
Good idea - @neinkeinkaffee if you wanted to do that (in a separate PR) it'd be welcome, else we can open it as an issue for others to take CI failures here are probably unrelated, if you fetch and merge upstream/master once CI is fixed they'll probably be fine |
@MarcoGorelli Sure, I'll add it to userguide/io.rst and submit a separate PR for that. Regarding the failing CI check of this one, do you mean I should just merge my branch with master again and that might fix it? |
Yeah, that's right - latest PRs seem to be mostly green, so if you fetch and merge upstream/master now that might be enough |
03b863b
to
c2d61c3
Compare
Updated with the most recent commits from master, hopefully that'll make the checks go green. I'll work on updating the io.rst on a separate branch. |
Actually, having a second look at io.rst I see that the documentation for each of the read and write methods is quite extensive there, containing lots of tips and tricks. Not sure if I can come up with something like that for |
No worries, I can open it up as an issue and someone else will take it! Thanks for your help on this one! |
@simonjayhawkins I've seen some recent docs PRs being tagged as 1.3, is that an OK milestone for this one too? |
examples
don't get substituted #42126