DEPR: Styler.render in favour of Styler.to_html
#42140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arse_args # Conflicts: # pandas/tests/io/formats/style/test_html.py
# Conflicts: # pandas/tests/io/formats/style/test_html.py # pandas/tests/io/formats/style/test_style.py
attack68
added
Deprecate
…arse_args # Conflicts: # doc/source/whatsnew/v1.4.0.rst
# Conflicts: # pandas/tests/io/formats/style/test_style.py
# Conflicts: # pandas/io/formats/style.py
attack68
changed the title
Styler.render in favour of Styler.to_htmlStyler.render in favour of Styler.to_html
…r_after # Conflicts: # pandas/io/formats/style.py
jreback
requested changes
Aug 5, 2021
…r_after # Conflicts: # doc/source/whatsnew/v1.4.0.rst # pandas/io/formats/style_render.py
|
can you rebase again, thanks |
…r_after # Conflicts: # doc/source/whatsnew/v1.4.0.rst
…r_after # Conflicts: # pandas/tests/io/formats/style/test_html.py # pandas/tests/io/formats/style/test_style.py
jreback
approved these changes
Aug 17, 2021
|
thanks @attack68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the method
Styler.render()in favour ofStyler.to_html(), which has been recently introduced and produces the same result under the default case of no arguments.Additionally this PR has added a test to a new file
pandas/tests/io/formats/style/test_deprecated.py, and it has moved some of the previous Styler deprecation tests into this file.