Skip to content

REGR: Subclassing Styler and addressing from_custom_template #42091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Jun 17, 2021

More info there - note that this makes the broken functionality re-available but is not backwards compatible due to inherited jinja2 templates.

The documentation is updated for the correct application.

Screen Shot 2021-06-17 at 23 48 54

@attack68 attack68 marked this pull request as ready for review June 17, 2021 22:03
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Jun 25, 2021
@jreback jreback added the Styler conditional formatting using DataFrame.style label Jun 25, 2021
@jreback
Copy link
Contributor

jreback commented Jun 25, 2021

can you merge master and have the CI run again.

@jreback jreback merged commit e6b57b9 into pandas-dev:master Jun 28, 2021
@jreback
Copy link
Contributor

jreback commented Jun 28, 2021

thanks @attack68

@jreback
Copy link
Contributor

jreback commented Jun 28, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 28, 2021

Something went wrong ... Please have a look at my logs.

jreback pushed a commit that referenced this pull request Jun 28, 2021
@attack68 attack68 deleted the regression_styler_subclassing_block_err branch June 28, 2021 23:11
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Styler subclassing and from_custom_template no longer working
3 participants