REGR: undocumented astype("category").astype(str) type inconsistency between pandas 1.1 & 1.2 #42087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
simonjayhawkins
commented
Jun 17, 2021
simonjayhawkins
commented
- closes BUG: undocumented astype("category").astype(str) type inconsistency between pandas 1.1 & 1.2 #41797
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
…between pandas 1.1 & 1.2
jreback
approved these changes
Jun 17, 2021
pandas/core/arrays/categorical.py
Outdated
| @@ -523,14 +523,17 @@ def astype(self, dtype: Dtype, copy: bool = True) -> ArrayLike: | |||
| try: | |||
| new_cats = np.asarray(self.categories) | |||
| new_cats = new_cats.astype(dtype=dtype, copy=copy) | |||
| fill_value = np.array(np.nan).astype(dtype).item() | |||
There was a problem hiding this comment.
there are cases where .item() has weird behavior and we use lib.item_from_zerodim instead. no idea if any of those cases are reachable here
|
thanks @simonjayhawkins |
This comment has been minimized.
This comment has been minimized.
|
@meeseeksdev backport 1.2.x |
|
@meeseeksdev backport 1.3.x |
This comment has been minimized.
This comment has been minimized.
|
cc @simonjayhawkins attempted backport to 1.2.x & 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jun 21, 2021
…stype(str) type inconsistency between pandas 1.1 & 1.2
1.3.x backport ok, 1.2.x needs manual. will do shortly. |
jreback
pushed a commit
that referenced
this pull request
Jun 21, 2021
… type inconsistency between pandas 1.1 & 1.2 (#42157) Co-authored-by: Simon Hawkins <[email protected]>
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
Jun 21, 2021
…stype(str) type inconsistency between pandas 1.1 & 1.2
simonjayhawkins
added a commit
that referenced
this pull request
Jun 21, 2021
… type inconsistency between pandas 1.1 & 1.2 (#42165)
neinkeinkaffee
pushed a commit
to neinkeinkaffee/pandas
that referenced
this pull request
Jun 21, 2021
…between pandas 1.1 & 1.2 (pandas-dev#42087)
3 tasks
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
…between pandas 1.1 & 1.2 (pandas-dev#42087)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.