Skip to content

Regression raising Error when having dup cols with single dtype for read csv #42030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2021
Merged

Regression raising Error when having dup cols with single dtype for read csv #42030

merged 2 commits into from
Jun 16, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Jun 15, 2021

regression on master, so no whatsnew

@phofl phofl added IO CSV read_csv, to_csv Regression Functionality that used to work in a prior pandas version labels Jun 15, 2021
@phofl phofl added this to the 1.3 milestone Jun 15, 2021
jreback
jreback requested changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for 1.3?

pandas/_libs/parsers.pyx Outdated
@@ -689,6 +689,7 @@ cdef class TextReader:
count = counts.get(name, 0)
if (
self.dtype is not None
and isinstance(self.dtype, dict)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use is_dict_like?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thx

@jreback
Copy link
Contributor

jreback commented Jun 15, 2021

is this for 1.3?

looks like it

@phofl
Copy link
Member Author

phofl commented Jun 15, 2021

Yes this is a regression on the rc

@jreback jreback merged commit f932831 into pandas-dev:master Jun 16, 2021
@jreback
Copy link
Contributor

jreback commented Jun 16, 2021

thanks @phofl

@meeseeksmachine meeseeksmachine mentioned this pull request Jun 16, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 16, 2021
@phofl @meeseeksmachine
Backport PR pandas-dev#42030: Regression raising Error when having du…
802a1dc 
…p cols with single dtype for read csv
@jreback
Copy link
Contributor

jreback commented Jun 16, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 16, 2021

Something went wrong ... Please have a look at my logs.

simonjayhawkins pushed a commit that referenced this pull request Jun 16, 2021
@meeseeksmachine @phofl
Backport PR #42030: Regression raising Error when having dup cols wit…
0e11a00 
…h single dtype for read csv (#42045)

Co-authored-by: Patrick Hoefler <[email protected]>
@phofl phofl deleted the 42022 branch June 16, 2021 08:45
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@phofl @JulianWgs
Regression raising Error when having dup cols with single dtype for r…
4bf468d 
…ead csv (pandas-dev#42030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
IO CSV read_csv, to_csv Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: read_csv now errors with non-dict dtype and same-name columns
2 participants
@phofl @jreback