REF: Refactor assert_index_equal #41980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
ref_assert_index_equal
branch
from
5e2197b to
2497c79
Compare
|
Everything passes localy, so seems like the CI failurees are unrelated. |
jreback
reviewed
Jun 16, 2021
| if check_categorical: | ||
| assert_attr_equal("dtype", left, right, obj=obj) | ||
| if is_categorical_dtype(left.dtype) and is_categorical_dtype(right.dtype): | ||
| if is_categorical_dtype(left.dtype) and is_categorical_dtype(right.dtype): |
There was a problem hiding this comment.
did this change any tests?
There was a problem hiding this comment.
I don't think so, right now. I think comparing dtype and inferred_type gives the same result for other dtypes that categoricals and numeric dtypes.
After #41153 we'll have int32 etc. dtypes, so then we'll have cases where it'll fail without this change.
topper-123
force-pushed
the
ref_assert_index_equal
branch
from
3c034a7 to
c34ae66
Compare
|
Rebased. |
jreback
added
Index
|
thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently some issues in
_check_dtypesinassert_index_equalrelated to #41153:assert_attr_equal("dtype", left, right, obj=obj)currently isn't run ifcheck_categoricalis False (even if the indexes are not CategoricalIndexes)assert_class_equalwithexact='equiv'should not be restricted to accept equivalence ofInt64IndexandRangeIndex, but should accept equivalence of all subclasses ofNumericIndex(in preparation for ENH: NumericIndex for any numpy int/uint/float dtype #41153).So, comparing numeric indexes with
assert_index_equal(idx1, idx2, exact="equiv")we should for otherwise equal content have:Conversely, with
exact=Trueclass comparison should be strict, so:This refactoring does not change behaviour in master, but will make #41153 easier.