Skip to content

BUG: UInt64Index.where with int64 value #41974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 15, 2021

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jun 12, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jbrockmendel jbrockmendel added Bug Index Related to the Index class or subclasses labels Jun 12, 2021
@simonjayhawkins
Copy link
Member

bug? needs a release note. I would put in 1.3 for now. (it can be moved if needed after @jreback reviews)

using semver we can make backwards compatible bug fixes in patch releases but we tend to only fix regressions.

from https://semver.org/

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards compatible manner, and
PATCH version when you make backwards compatible bug fixes.

@jreback jreback added this to the 1.3 milestone Jun 15, 2021
@jreback jreback merged commit 9a2d2b6 into pandas-dev:master Jun 15, 2021
@jreback
Copy link
Contributor

jreback commented Jun 15, 2021

this is fine for 1.3

@jreback
Copy link
Contributor

jreback commented Jun 15, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 15, 2021

Something went wrong ... Please have a look at my logs.

@jbrockmendel jbrockmendel deleted the bug-where-uint64 branch June 16, 2021 00:26
simonjayhawkins pushed a commit that referenced this pull request Jun 16, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Index Related to the Index class or subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants