Skip to content

Bug in melt raising Error with dup columns as value vars #41964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2021
Merged

Bug in melt raising Error with dup columns as value vars #41964

merged 1 commit into from
Jun 15, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Jun 12, 2021 •
edited
Loading

@simonjayhawkins I think this changed in May last year, so probably not woth backporting?

@phofl phofl added Regression Functionality that used to work in a prior pandas version Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jun 12, 2021
simonjayhawkins
simonjayhawkins requested changes Jun 12, 2021
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonjayhawkins I think this changed in May last year, so probably not woth backporting?

i'll do a bisect to confirm and decide from there

@jreback jreback added this to the 1.3 milestone Jun 15, 2021
@jreback jreback merged commit 0f3e53f into pandas-dev:master Jun 15, 2021
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 15, 2021
Merged
@jreback
Copy link
Contributor

jreback commented Jun 15, 2021

thanks @phofl

this seemed simple enough

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 15, 2021
@phofl @meeseeksmachine
Backport PR pandas-dev#41964: Bug in melt raising Error with dup colu…
1978024 
…mns as value vars
simonjayhawkins pushed a commit that referenced this pull request Jun 16, 2021
@meeseeksmachine @phofl
Backport PR #41964: Bug in melt raising Error with dup columns as val…
9ac9699 
…ue vars (#42035)

Co-authored-by: Patrick Hoefler <[email protected]>
@phofl phofl deleted the 41951 branch June 16, 2021 08:46
@simonjayhawkins
Copy link
Member

@simonjayhawkins I think this changed in May last year, so probably not woth backporting?

can confirm, first bad commit: [62c7dd3] Fix MultiIndex melt when col_level is used (#34329)

This looks like it would be a straightfoward backport. I see no harm in backporting as it's a regression, but would need release notes moving first so that autobackports work.

@phofl
Copy link
Member Author

phofl commented Jun 17, 2021

Meaning opening a new PR for the Whatsnew before backporting this?

@simonjayhawkins
Copy link
Member

Meaning opening a new PR for the Whatsnew before backporting this?

yes. @jreback thoughts on including this regression fix in 1.2.5? (it was a regression in 1.1)

@jreback
Copy link
Contributor

jreback commented Jun 18, 2021

prob not worth backport to 1.2.x

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@phofl @JulianWgs
Bug in melt raising Error with dup columns as value vars (pandas-dev#…
2dba086 
…41964)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins requested changes

Assignees
No one assigned
Labels
Regression Functionality that used to work in a prior pandas version Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

DataFrame.melt fails if there are duplicate value_vars
3 participants
@phofl @jreback @simonjayhawkins