REGR: Series[dt64/td64].astype(string) #41958
Conversation
simonjayhawkins
added
the
Regression
| @@ -712,6 +712,14 @@ cpdef ndarray[object] ensure_string_array( | |||
| Py_ssize_t i = 0, n = len(arr) | |||
|
|
|||
| if hasattr(arr, "to_numpy"): | |||
|
|
|||
| if hasattr(arr, "dtype") and arr.dtype.kind in ["m", "M"]: | |||
There was a problem hiding this comment.
agreed, yeah the .to_numpy() on an EA is the approparate here.
| @@ -660,6 +656,15 @@ def test_astype_dt64_to_string(self, frame_or_series, tz_naive_fixture, request) | |||
| alt = obj.astype(str) | |||
| assert np.all(alt.iloc[1:] == result.iloc[1:]) | |||
|
|
|||
| def test_astype_td64_to_string(self, frame_or_series): | |||
There was a problem hiding this comment.
can you parametersize over td, dt, dt w/tz & period
There was a problem hiding this comment.
not nicely; the dt64 one uses tz_naive_fixture
There was a problem hiding this comment.
ok can you add that as another test then. just to make sure coverng the bases.
There was a problem hiding this comment.
add what as another case? we have the td64 case here and the dt64 case right above here
There was a problem hiding this comment.
ahh ok.
period covered? if not pls add (followup ok)
| @@ -660,6 +656,15 @@ def test_astype_dt64_to_string(self, frame_or_series, tz_naive_fixture, request) | |||
| alt = obj.astype(str) | |||
| assert np.all(alt.iloc[1:] == result.iloc[1:]) | |||
|
|
|||
| def test_astype_td64_to_string(self, frame_or_series): | |||
There was a problem hiding this comment.
ok can you add that as another test then. just to make sure coverng the bases.
| @@ -716,6 +716,14 @@ cpdef ndarray[object] ensure_string_array( | |||
| Py_ssize_t i = 0, n = len(arr) | |||
|
|
|||
| if hasattr(arr, "to_numpy"): | |||
There was a problem hiding this comment.
we dont' have access to the ExtnsionTypes here right? so this is just as easy
|
@meeseeksdev backport 1.3.x |
|
Something went wrong ... Please have a look at my logs. |
Co-authored-by: jbrockmendel <[email protected]>
This surfaces another bug in
StringArray.__getitem__that I haven't looked into yet.