Skip to content

BUG: (GH4192) Fixed buglet in the broadcasting logic in Series.where #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2013
Merged

BUG: (GH4192) Fixed buglet in the broadcasting logic in Series.where #4195

merged 2 commits into from
Jul 10, 2013

Conversation

SleepingPills
Copy link
Contributor

Fixed #4192

@jreback
Copy link
Contributor

jreback commented Jul 10, 2013

======================================================================
FAIL: test_where (pandas.tests.test_series.TestSeries)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/pandas-0.12.0rc1-py2.7-linux-x86_64.egg/pandas/tests/test_series.py", line 1139, in test_where
    self.assertRaises(ValueError, s.__setitem__, mask, ([0]*5,))
AssertionError: ValueError not raised

@jreback
Copy link
Contributor

jreback commented Jul 10, 2013

fyi...travis runs on 32-bit (not that this caused this error)

@jreback
Copy link
Contributor

jreback commented Jul 10, 2013

in the future, you can use vagrantup.com to setup a machine in any configuration you want...

@jreback
Copy link
Contributor

jreback commented Jul 10, 2013

everything passes for me now (on 32/64) bit

@jreback
Copy link
Contributor

jreback commented Jul 10, 2013

look good, merge?

@jreback
Copy link
Contributor

jreback commented Jul 10, 2013

I'll just take out the print statements.....

@jreback
Copy link
Contributor

jreback commented Jul 10, 2013

so was a one-line change! hah

@jreback jreback merged commit fdbba96 into pandas-dev:master Jul 10, 2013
@jreback
Copy link
Contributor

jreback commented Jul 10, 2013

thank you sir!

@SleepingPills
Copy link
Contributor Author

Oops, sorry about the print statements. I had to hurry quite a bit due to some other work and didn't realize that I left some debug stuff in there. I'll take greater care next time.

@SleepingPills SleepingPills deleted the where_bool_broadcast branch July 11, 2013 02:20
@jreback
Copy link
Contributor

jreback commented Jul 11, 2013

np......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Boolean indexed assignment
2 participants