[ArrayManager] Enable pytables IO by falling back to BlockManager #41944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorisvandenbossche only PRs for the rc are milestoned 1.3 for now to help track our readiness for the rc, otherwise they are milestone as they are merged. Is this for the rc or can I remove the milestone for now? |
jreback
added
Internals
|
this is fine. @jorisvandenbossche can you open an issue for the impl in AM . |
|
It's mentioned as one of the bullet points in #39146 |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't "fix" anything, but by falling back for now to the BlockManager-specific implementation of
to_hdfwriter, this avoids failures when using ArrayManager, which should make it easier to test it.