BUG: Categorical.fillna with non-category tuple #41914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jun 9, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
| # not NotImplementedError GH#41914 | ||
| cat = Categorical(np.array([Point(1, 0), Point(0, 1), None], dtype=object)) | ||
| msg = "Cannot setitem on a Categorical with a new category" | ||
| with pytest.raises(ValueError, match=msg): |
There was a problem hiding this comment.
This is ValueError whereas in #41919 changed to TypeError with the same message?
There was a problem hiding this comment.
yes, this should eventually be TypeError
simonjayhawkins
added
Bug
Categorical
jreback
approved these changes
Jun 10, 2021
| # Case where the Point is not among our categories; we want ValueError, | ||
| # not NotImplementedError GH#41914 | ||
| cat = Categorical(np.array([Point(1, 0), Point(0, 1), None], dtype=object)) | ||
| msg = "Cannot setitem on a Categorical with a new category" |
There was a problem hiding this comment.
is it possible to customize the error messages to the caller method (eg fill a here) as we have a generic validate (good)
can be a follow on
There was a problem hiding this comment.
yah thatd be nice. we did something like that for the datetimelikes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.