DOC clean up positional-args deprecation warnings in whatsnew #41908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MarcoGorelli
commented
Jun 9, 2021
MarcoGorelli
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
MarcoGorelli
force-pushed
the
tidy-up-deprecations-in-whatsnew
branch
from
8c2b8f7 to
d2fb0f9
Compare
MarcoGorelli
force-pushed
the
tidy-up-deprecations-in-whatsnew
branch
from
d2fb0f9 to
aabbc81
Compare
jbrockmendel
reviewed
Jun 9, 2021
| - :meth:`DataFrame.where` and :meth:`Series.where` (other than ``cond`` and ``other``) | ||
| - :meth:`Index.set_names` and :meth:`MultiIndex.set_names` (except for ``names``) | ||
| - :meth:`MultiIndex.codes` (except for ``codes``) | ||
| - :meth:`MultiIndex.set_levels` (except for ``levels``) |
There was a problem hiding this comment.
nitpick: since this is standardizing wording, could standardize "other than" vs "except for"
|
Thanks @MarcoGorelli i'll merge this as already an improvement. can address @jbrockmendel comment in a follow-up |
|
@MarcoGorelli this hasn't rendered correctly as a list https://pandas.pydata.org/pandas-docs/dev/whatsnew/v1.3.0.html#deprecations |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.