Skip to content

BENCH: Remove unnecessary random seeds #41889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

We are implementing a common seed explained in https://asv.readthedocs.io/en/latest/writing_benchmarks.html.

Added a code check as well

@mroeschke mroeschke added Benchmark Performance (ASV) benchmarks CI Continuous Integration labels Jun 9, 2021
@mroeschke mroeschke added this to the 1.3 milestone Jun 9, 2021
@jreback jreback merged commit 4a00fcc into pandas-dev:master Jun 9, 2021
@jreback
Copy link
Contributor

jreback commented Jun 9, 2021

thanks @mroeschke

@mroeschke mroeschke deleted the asv/no_seed branch June 9, 2021 15:49
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants