Skip to content

REF: simplify indexes.base._maybe_cast_data_without_dtype #41881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 10, 2021
Merged

REF: simplify indexes.base._maybe_cast_data_without_dtype #41881

merged 4 commits into from
Jun 10, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jbrockmendel jbrockmendel added Constructors Series/DataFrame/Index/pd.array Constructors Index Related to the Index class or subclasses Refactor Internal refactoring of code labels Jun 8, 2021
jreback
jreback approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. any perf change?

@jreback jreback added this to the 1.3 milestone Jun 10, 2021
@jbrockmendel
Copy link
Member Author

any perf change?

i did some timeits and it was a wash

@jreback jreback merged commit 90099df into pandas-dev:master Jun 10, 2021
@jbrockmendel jbrockmendel deleted the enh-maybe_convert_objects-inferred branch June 10, 2021 16:00
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
REF: simplify indexes.base._maybe_cast_data_without_dtype (pandas-dev…
882a2c1 
…#41881)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Index Related to the Index class or subclasses Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback