-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: unstack with object dtype of tzaware timestamps #41875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jbrockmendel
commented
Jun 8, 2021
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
@@ -1095,6 +1095,7 @@ Reshaping | |||
- Bug in :func:`to_datetime` raising an error when the input sequence contained unhashable items (:issue:`39756`) | |||
- Bug in :meth:`Series.explode` preserving the index when ``ignore_index`` was ``True`` and values were scalars (:issue:`40487`) | |||
- Bug in :func:`to_datetime` raising a ``ValueError`` when :class:`Series` contains ``None`` and ``NaT`` and has more than 50 elements (:issue:`39882`) | |||
- Bug in :meth:`Series.unstack` and :meth:`DataFrame.unstack` with object-dtype values containing timezone-aware datetime objects incorrectly raising ``TypeError`` (:issue:`41875`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we not have a test that changed for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we recently changed the test for period and interval. This makes the same change to that test for dt64tz
this is ok for 1.3, can you rebase |
@meeseeksdev backport 1.3.x |
Something went wrong ... Please have a look at my logs. |
…mps (#42062) Co-authored-by: jbrockmendel <[email protected]>
It seems that it's not fixed for the case where mask_all is true. I'll send another PR pandas/pandas/core/reshape/reshape.py Line 294 in 42082a8
|
This is a follow up to pandas-dev#41875
This is a follow up to pandas-dev#41875
This is a follow up to pandas-dev#41875
This is a follow up to pandas-dev#41875
This is a follow up to pandas-dev#41875
This is a follow up to pandas-dev#41875
This is a follow up to pandas-dev#41875
This is a follow up to pandas-dev#41875
This is a follow up to pandas-dev#41875
This is a follow up to pandas-dev#41875
BUG: `pivot_table` chokes on pd.DatetimeTZDtype if there are no rows. This is a follow up to #41875