Skip to content

Tst interval index NaN uniqueness #41870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

r-toroxel
Copy link
Contributor

add test cases for interval-indexer with unique NaN value and non-unique NaN values.

@simonjayhawkins
Copy link
Member

Thanks @r-toroxel is this not currently tested or is it one of the open issues that are fixed on master

is this related to #41831 and the associated open PR #41863

@simonjayhawkins simonjayhawkins added Interval Interval data type Testing pandas testing functions or related to the test suite labels Jun 8, 2021
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r-toroxel
Copy link
Contributor Author

r-toroxel commented Jun 9, 2021

@simonjayhawkins yes, these were not tested before and seem to be related to #41831.

@jreback jreback added this to the 1.3 milestone Jun 9, 2021
@jreback jreback merged commit 8b9b1a1 into pandas-dev:master Jun 9, 2021
@jreback
Copy link
Contributor

jreback commented Jun 9, 2021

thanks @r-toroxel

@jreback
Copy link
Contributor

jreback commented Jun 9, 2021

@jbrockmendel does this close #41831 ?

@r-toroxel
Copy link
Contributor Author

@jreback I'm afraid it does not fix the bug and hence close the issue. just a test added.

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interval Interval data type Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants