TYP: datetimelike #41830
Merged
TYP: datetimelike #41830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jun 5, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
requested changes
Jun 10, 2021
| @@ -178,9 +180,9 @@ def test_dt_accessor_api_for_categorical(self): | |||
| get_ops = lambda x: x._datetimelike_ops | |||
|
|
|||
| test_data = [ | |||
| ("Datetime", get_ops(DatetimeIndex), s_dr, c_dr), | |||
| ("Datetime", get_ops(DatetimeArray), s_dr, c_dr), | |||
There was a problem hiding this comment.
shouldn't the index accessors work as well here (eg the intent of the test is that)
There was a problem hiding this comment.
yah, its just the lists DatetimeIndex._foo_ops that we stop inheriting
jreback
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.