Skip to content

BLD: Adjust Numpy Minimum Versions for aarch64/arm64 compatibility #41788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2021
Merged

BLD: Adjust Numpy Minimum Versions for aarch64/arm64 compatibility #41788

merged 3 commits into from
Jun 21, 2021

Conversation

lithomas1
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

fangchenli
fangchenli reviewed Jun 3, 2021
View reviewed changes
@lithomas1 lithomas1 changed the title WIP: BLD: Require numpy>1.20 for ARM64 WIP: BLD: Adjust Numpy Minimum Versions for aarch64/arm64 compatibility Jun 5, 2021
@lithomas1 lithomas1 marked this pull request as ready for review June 5, 2021 17:45
@lithomas1 lithomas1 added Build Library building on various platforms ARM aarch64 architecture labels Jun 5, 2021
@lithomas1 lithomas1 changed the title WIP: BLD: Adjust Numpy Minimum Versions for aarch64/arm64 compatibility BLD: Adjust Numpy Minimum Versions for aarch64/arm64 compatibility Jun 5, 2021
@lithomas1 lithomas1 requested a review from jreback June 19, 2021 18:14
@fangchenli
Copy link
Member

We need to backport this. Currently, pip install pandas --pre doesn't work on M1 mac.

@fangchenli fangchenli added this to the 1.3 milestone Jun 20, 2021
@jreback
Copy link
Contributor

jreback commented Jun 20, 2021

ok let me look

we should merge the sdist test first

@jreback jreback merged commit 74a1e67 into pandas-dev:master Jun 21, 2021
@jreback
Copy link
Contributor

jreback commented Jun 21, 2021

thanks @lithomas1

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 21, 2021
@lithomas1 @meeseeksmachine
Backport PR pandas-dev#41788: BLD: Adjust Numpy Minimum Versions for …
726ff1b 
…aarch64/arm64 compatibility
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 21, 2021
Merged
@jreback
Copy link
Contributor

jreback commented Jun 21, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 21, 2021

Something went wrong ... Please have a look at my logs.

@lithomas1 lithomas1 deleted the patch-2 branch June 21, 2021 15:14
simonjayhawkins pushed a commit that referenced this pull request Jun 21, 2021
@meeseeksmachine @lithomas1
Backport PR #41788: BLD: Adjust Numpy Minimum Versions for aarch64/ar…
1c55796 
…m64 compatibility (#42156)

Co-authored-by: Thomas Li <[email protected]>
neinkeinkaffee pushed a commit to neinkeinkaffee/pandas that referenced this pull request Jun 21, 2021
@lithomas1 @neinkeinkaffee
BLD: Adjust Numpy Minimum Versions for aarch64/arm64 compatibility (p…
846c907 
…andas-dev#41788)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@lithomas1 @JulianWgs
BLD: Adjust Numpy Minimum Versions for aarch64/arm64 compatibility (p…
c24e01d 
…andas-dev#41788)
@aptalca
Copy link
Contributor

aptalca commented Sep 23, 2021

Hi,
It looks like this PR incorrectly excluded all python 3.9 numpy version requirements on aarch64 and since the backports, I can't build any pandas 1.3.X versions on aarch64 with python 3.9.

Opened a PR to fix it: #43722 just fyi

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangchenli fangchenli fangchenli left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
ARM aarch64 architecture Build Library building on various platforms
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@lithomas1 @fangchenli @jreback @aptalca