Skip to content

TST: Do not skip MySQL tests on Travis. #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2013

Conversation

danielballan
Copy link
Contributor

A first step for #4163

@@ -12,4 +12,5 @@ xlrd==0.9.2
patsy==0.1.0
html5lib==1.0b2
lxml==3.2.1
MySQL-python==1.2.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you only want to test this on 2.7? if not then please add it to the other requirements files. Might be good to test on Python >= 2.7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MySQLdb currently does not support Python 3. See https://github.com/farcepest/MySQLdb1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know, thanks.

@danielballan
Copy link
Contributor Author

The build failed because of something in pandas.io.tests.test_data.TestYahoo. Should I just try pushing again? Previous test on the exact same code passed.

The error is small, and moreover it's unrelated to my changes.

AssertionError: 
Arrays are not almost equal to 5 decimals expected 904.91000 but got 904.90000

@cpcloud
Copy link
Member

cpcloud commented Jul 9, 2013

rebase off of master and try again, i just merged a commit to fix that

@hayd hayd mentioned this pull request Jul 9, 2013
20 tasks
@danielballan
Copy link
Contributor Author

Full speed ahead.

@hayd
Copy link
Contributor

hayd commented Jul 9, 2013

2.7 build sulking a little:

/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/pandas-0.12.0rc1-py2.7-linux-x86_64.egg/pandas/io/tests/test_sql.py:391: Warning: Unknown table 'test_table'
  cur.execute(drop_sql)
/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/pandas-0.12.0rc1-py2.7-linux-x86_64.egg/pandas/io/tests/test_sql.py:408: Warning: Unknown table 'test_table2'
  cur.execute(drop_sql)
./home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/pandas-0.12.0rc1-py2.7-linux-x86_64.egg/pandas/io/tests/test_sql.py:300: Warning: Unknown table 'test'
  cur.execute(drop_sql)

@hayd
Copy link
Contributor

hayd commented Jul 10, 2013

Is this running all the tests now? Merge?

@danielballan
Copy link
Contributor Author

Merge.

hayd added a commit that referenced this pull request Jul 10, 2013
TST: Do not skip MySQL tests on Travis.
@hayd hayd merged commit cb10923 into pandas-dev:master Jul 10, 2013
@danielballan danielballan deleted the mysql-on-travis branch July 10, 2013 18:32
@jreback
Copy link
Contributor

jreback commented Jul 10, 2013

does this also correct skip when mysql not installed?

@danielballan
Copy link
Contributor Author

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants