-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Do not skip MySQL tests on Travis. #4177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -12,4 +12,5 @@ xlrd==0.9.2 | |||
patsy==0.1.0 | |||
html5lib==1.0b2 | |||
lxml==3.2.1 | |||
MySQL-python==1.2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you only want to test this on 2.7? if not then please add it to the other requirements files. Might be good to test on Python >= 2.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MySQLdb currently does not support Python 3. See https://github.com/farcepest/MySQLdb1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to know, thanks.
The build failed because of something in The error is small, and moreover it's unrelated to my changes.
|
rebase off of master and try again, i just merged a commit to fix that |
Full speed ahead. |
2.7 build sulking a little:
|
Is this running all the tests now? Merge? |
Merge. |
TST: Do not skip MySQL tests on Travis.
does this also correct skip when mysql not installed? |
Yes. |
A first step for #4163