CLN: Remove travis build #41738
Merged
CLN: Remove travis build #41738
+0
−226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
May 31, 2021
| @@ -63,29 +63,6 @@ conda update -n base conda | |||
| echo "conda info -a" | |||
| conda info -a | |||
|
|
|||
| echo | |||
| echo "set the compiler cache to work" | |||
| if [ -z "$NOCACHE" ] && [ "${TRAVIS_OS_NAME}" == "linux" ]; then | |||
There was a problem hiding this comment.
umm is this just not used elsewhere? it seems the builds are now taking a lot longer.
There was a problem hiding this comment.
Thanks for the heads up. I double checked, and there is nowhere in our code where we set TRAVIS_OS_NAME, so I don't see how any of the conditions here can be true.
I checked the builds, and the only I see that was significantly slower was a Windows one, which doesn't use this file. I guess it's been just randomness, but in any case, I rebased, and if there is anything still significantly slow, I'll have another look.
There was a problem hiding this comment.
hmm yeah this might have been old ok great
jreback
approved these changes
Jun 1, 2021
| @@ -63,29 +63,6 @@ conda update -n base conda | |||
| echo "conda info -a" | |||
| conda info -a | |||
|
|
|||
| echo | |||
| echo "set the compiler cache to work" | |||
| if [ -z "$NOCACHE" ] && [ "${TRAVIS_OS_NAME}" == "linux" ]; then | |||
There was a problem hiding this comment.
hmm yeah this might have been old ok great
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we can assume that Travis is not an option for ARM builds (or any other builds due to the lack of free credits), this is the PR that removes all travis specific stuff.