[ArrowStringArray] ENH: raise an ImportError when trying to create an arrow string dtype if pyarrow is not installed #41732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arrow string dtype if pyarrow is not installed
4 tasks
|
|
||
|
|
||
| @pytest.mark.skipif( | ||
| pa_version_under1p0, | ||
| reason="pyarrow>=1.0.0 is required for PyArrow backed StringArray", |
There was a problem hiding this comment.
should the numpy test still run?
There was a problem hiding this comment.
self._dtype = ArrowStringDtype() is defined in __init__ before the input is checked. creating an instance ArrowStringDtype now raises an ImportError, tested in the test added.
There was a problem hiding this comment.
actually we checked pyarrow was availble before with self._chk_pyarrow_available() but this module was skipped with pytest.importorskip("pyarrow", minversion="1.0.0")
|
this ok before #39908 ? @simonjayhawkins |
either, conflicts either way. (just wanted to keep this change separate) |
|
thanks @simonjayhawkins |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
… arrow string dtype if pyarrow is not installed (pandas-dev#41732)
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
… arrow string dtype if pyarrow is not installed (pandas-dev#41732)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #39908 (comment)