Skip to content

DOC: Updates Index.any docstring from #40362 #41726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Beluuuuuuga
Copy link

@Beluuuuuuga Beluuuuuuga commented May 29, 2021

  • closes DOC: Wrong examples  #40362: add an introduction to all() function as described in "See also"
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added the Docs label Jun 4, 2021
@jreback jreback added this to the 1.3 milestone Jun 4, 2021
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Beluuuuuuga from the OP

The examples of 'pandas.Index.any' are also included in its own page.

I think my preference would be to delete the any examples from the all method docstring.

If we are adding as here, can we shares the examples instead to make them consistent.

@simonjayhawkins simonjayhawkins removed this from the 1.3 milestone Jun 8, 2021
@Beluuuuuuga
Copy link
Author

Beluuuuuuga commented Jun 8, 2021

@simonjayhawkins

I think my preference would be to delete the any examples from the all method docstring.
If we are adding as here, can we shares the examples instead to make them consistent.

Can I just commit the deleted example as well as the one I added this time?
Or should I submit a new pull request?

@simonjayhawkins
Copy link
Member

Or should I submit a new pull request?

you can push changes to the same PR as it's the same issue.

@Beluuuuuuga
Copy link
Author

@simonjayhawkins

I'll commit this week.

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jul 10, 2021
@MarcoGorelli
Copy link
Member

@Beluuuuuuga is this still active?

@Beluuuuuuga
Copy link
Author

@Beluuuuuuga is this still active?

Sorry for the delay. I'll do it tomorrow.

@MarcoGorelli
Copy link
Member

sure, no hurry

@mroeschke
Copy link
Member

Thanks for the PR, but it appears to have gone stale. Closing due to inactivity but feel free to push updates to your branch and when you're ready for another review we can reopen.

@mroeschke mroeschke closed this Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Wrong examples
5 participants