Skip to content

BUG: DataFrameGroupBy with numeric_only and empty non-numeric data #41706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 2, 2021
Merged

BUG: DataFrameGroupBy with numeric_only and empty non-numeric data #41706

merged 12 commits into from
Jun 2, 2021

Conversation

jbrockmendel
Copy link
Member

@jreback jreback mentioned this pull request May 31, 2021
Closed
4 tasks
@jreback jreback added Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Reduction Operations sum, mean, min, max, etc. labels May 31, 2021
jreback
jreback approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok with merging (comment though on the huge test backing this).

is this rebased? (as merged a change that we backported to 1.2.5)

pandas/tests/groupby/test_groupby.py
@@ -1861,6 +1861,49 @@ def get_result():
get_result()

return
else:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is gigantic. umm can you split up (may not be easy).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressing this is a follow-on, yah

@jreback jreback added this to the 1.3 milestone Jun 2, 2021
@jreback jreback merged commit 6b94e24 into pandas-dev:master Jun 2, 2021
@jbrockmendel jbrockmendel deleted the ref-numeric_only-dfgb branch June 2, 2021 16:59
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
BUG: DataFrameGroupBy with numeric_only and empty non-numeric data (p…
d1ad5c9 
…andas-dev#41706)
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 14, 2021
Closed
3 tasks
This was referenced Aug 25, 2021
Closed
Merged
@simonjayhawkins simonjayhawkins mentioned this pull request Sep 1, 2021
Merged
4 tasks
simonjayhawkins referenced this pull request Sep 10, 2021
@Dr-Irv
add FutureWarning. Avoid Int64Index
d46091e
@simonjayhawkins simonjayhawkins mentioned this pull request Sep 10, 2021
Closed
3 tasks
@simonjayhawkins simonjayhawkins mentioned this pull request Jun 10, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Reduction Operations sum, mean, min, max, etc.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

API: SeriesGroupBy.product with numeric_only and empty non-numeric data
2 participants
@jbrockmendel @jreback