Skip to content

TST: More old issues #41697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 28, 2021
Merged

TST: More old issues #41697

merged 11 commits into from
May 28, 2021

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label May 28, 2021
@mroeschke mroeschke added this to the 1.3 milestone May 28, 2021
simonjayhawkins
simonjayhawkins approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mroeschke lgtm. one suggestion.

pandas/tests/indexing/multiindex/test_loc.py Outdated
}
)
df = df.set_index(["A", "B"])
with pytest.raises(KeyError, match="1"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with pytest.raises(KeyError, match="1"):
with pytest.raises(KeyError, match="^1$"):

jreback
jreback approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, ex @simonjayhawkins comment

@jreback jreback merged commit a811c96 into pandas-dev:master May 28, 2021
@jreback
Copy link
Contributor

jreback commented May 28, 2021

thanks @mroeschke

@mroeschke mroeschke deleted the tests/old_issues branch May 28, 2021 19:14
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
@mroeschke @TLouf
TST: More old issues (pandas-dev#41697)
aaecadb
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@mroeschke @JulianWgs
TST: More old issues (pandas-dev#41697)
d981397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.3
3 participants
@mroeschke @jreback @simonjayhawkins