Skip to content

Add test for fixed regression in concat with empty DataFrames #41677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 28, 2021
Merged

Add test for fixed regression in concat with empty DataFrames #41677

merged 6 commits into from
May 28, 2021

Conversation

weikhor
Copy link
Contributor

@weikhor weikhor commented May 26, 2021

@pep8speaks
Copy link

pep8speaks commented May 26, 2021 •
edited
Loading

Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-28 15:24:46 UTC

@simonjayhawkins simonjayhawkins added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite labels May 26, 2021
@simonjayhawkins
Copy link
Member

@weikhor thanks for the PR. lint issue to resolve.

@weikhor weikhor mentioned this pull request May 26, 2021
Closed
charlesdong1991
charlesdong1991 suggested changes May 26, 2021
View reviewed changes
Copy link
Member

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to create empty dataframes directly instead of using [0:0] or [:0] ?

@weikhor
Copy link
Contributor Author

weikhor commented May 27, 2021 •
edited
Loading

Hi I have make change to code. Thank

charlesdong1991
charlesdong1991 suggested changes May 27, 2021
View reviewed changes
Copy link
Member

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, i triggered the complete tests for you and probably one job will fail (on the double quote).

@weikhor
Copy link
Contributor Author

weikhor commented May 28, 2021

Hi Thank for review. Have making changes to codes.

@jreback jreback added this to the 1.3 milestone May 28, 2021
@jreback
Copy link
Contributor

jreback commented May 28, 2021

looks fine, let's see what the CI says

@jreback jreback merged commit 73f4711 into pandas-dev:master May 28, 2021
@jreback
Copy link
Contributor

jreback commented May 28, 2021

thanks @weikhor

TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
@TLouf
Add test for fixed regression in concat with empty DataFrames (pandas…
5719d73 
…-dev#41677)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@JulianWgs
Add test for fixed regression in concat with empty DataFrames (pandas…
ad1d890 
…-dev#41677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesdong1991 charlesdong1991 charlesdong1991 requested changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

REGR: concat of unaligned empty DataFrames failing
5 participants
@weikhor @pep8speaks @simonjayhawkins @jreback @charlesdong1991