TST: Check float format in object column (#35603) #41668

mdhsieh · 2021-05-25T22:11:50Z

closes BUG: Incorrect float format in object column #35603
tests added / passed
Ensure all linting tests pass, see here for how to run them
whatsnew entry

This test checks if a Series cast to object still shows data in float format.

Ran pytest pandas/tests/series/test_constructors.py
Output:

================================================= test session starts =================================================
platform win32 -- Python 3.8.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: C:\Users\mdhsi\pandas-michael, configfile: pyproject.toml
plugins: hypothesis-6.12.0, asyncio-0.14.0, cov-2.11.1, forked-1.3.0, instafail-0.4.1, xdist-2.2.1
collected 301 items

pandas\tests\series\test_constructors.py .......................................................................................................................................................................................................x.....................................................................................................

--------------------------- generated xml file: C:\Users\mdhsi\pandas-michael\test-data.xml ---------------------------
================================================ slowest 30 durations =================================================
0.25s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_empty_constructor[<lambda>-True0]
0.13s call     pandas/tests/series/test_constructors.py::TestSeriesConstructorIndexCoercion::test_series_constructor_datetimelike_index_coercion
0.09s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive['dateutil/US/Pacific'-True]
0.04s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_dtype_datetime64_10
0.02s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_empty[OrderedDict]
0.02s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_empty[dict]
0.02s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_cant_cast_datetimelike[PeriodIndex]
0.02s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_cant_cast_datetimelike[DatetimeIndex]
0.02s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_cant_cast_datetimelike[TimedeltaIndex]
0.02s setup    pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_datetimelike_scalar_to_string_dtype[string]
0.02s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_pass_none
0.02s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_categorical_with_coercion
0.02s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_dtype_timedelta64
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive[pytz.FixedOffset(300)-False]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive['Asia/Tokyo'-True]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive[pytz.FixedOffset(300)-True]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive[tzlocal()-False]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive['dateutil/Asia/Singapore'-False]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive[datetime.timezone(datetime.timedelta(seconds=3600))-False]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive[tzutc()-False]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive['+01:15'-True]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive['UTC'-False]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive['UTC-02:15'-True]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive[tzlocal()-True]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive[pytz.FixedOffset(-300)-True]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive['dateutil/Asia/Singapore'-True]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive['UTC'-True]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive['-02:15'-False]
0.01s call     pandas/tests/series/test_constructors.py::TestSeriesConstructors::test_constructor_data_aware_dtype_naive[pytz.FixedOffset(-300)-False]
=========================================== 300 passed, 1 xfailed in 2.22s ============================================

…das-dev#35603).

…mal point. May not be good idea to use == to compare floating-point numbers.

pep8speaks · 2021-05-25T22:11:53Z

Hello @mdhsieh! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-27 17:30:45 UTC

To fix PEP8 issues.

mzeitlin11 · 2021-05-26T00:05:19Z

Thanks for the pr @mdhsieh! If you look at the linked issue, we actually want to be testing output formatting, not construction. The test should essentially make sure that printing the series from the issue gives the expected result (hardcoded as a string).

mdhsieh · 2021-05-26T17:24:11Z

Oh ok, I'll change it. Should the test be moved to tests/series/test_repr folder then?

Needs to be rewritten to check formatting not construction.

Checks if series representation matches expected String.

mzeitlin11 · 2021-05-26T17:56:57Z

Oh ok, I'll change it. Should the test be moved to tests/series/test_repr folder then?

Either there or pandas/tests/io/formats/test_format.py, not 100% sure so whichever looks like it has more similar tests to the one you write. (will be easy to change location once test is written, so don't worry too much about it :)

jreback

pls merge master and fix the linting issues.

jreback · 2021-05-27T13:59:44Z

pandas/tests/series/test_repr.py

@@ -240,6 +240,15 @@ def test_series_repr_nat(self):
        )
        assert result == expected

+    def test_float_repr_in_frame(self):


can you remove _in_frame (as this a series).

It is a Series not a DataFrame.

…object-float

They should not be there.

Failed pre-commit check since want 2 newlines before defining class, but only had 1.

jreback · 2021-05-27T18:41:10Z

thanks @mdhsieh

…ev#41668)

mdhsieh added 2 commits May 25, 2021 14:09

TST: Check Series when cast to object has float in object column (pan…

6fe3936

…das-dev#35603).

TST: Assert equality with float was changed to assert string has deci…

3f14a96

…mal point. May not be good idea to use == to compare floating-point numbers.

TST: Remove whitespace before and after the new test.

a1b5dd2

To fix PEP8 issues.

mzeitlin11 added Output-Formatting __repr__ of pandas objects, to_string Testing pandas testing functions or related to the test suite labels May 26, 2021

mdhsieh added 2 commits May 26, 2021 10:28

TST: Remove new test.

75786bd

Needs to be rewritten to check formatting not construction.

TST: Rewrite and move new test to test_repr folder (pandas-dev#35603).

24b70be

Checks if series representation matches expected String.

jreback added this to the 1.3 milestone May 27, 2021

jreback requested changes May 27, 2021

View reviewed changes

mdhsieh added 4 commits May 27, 2021 10:03

TST: Remove in_frame from function name.

51f5169

It is a Series not a DataFrame.

Merge remote-tracking branch 'upstream/master' into 35603-tst-series-…

cd865bc

…object-float

tst: Remove parentheses to try fix linting issue.

72c07f8

They should not be there.

TST: Add newline to fix linting issue.

968004b

Failed pre-commit check since want 2 newlines before defining class, but only had 1.

jreback approved these changes May 27, 2021

View reviewed changes

jreback merged commit 1a20d13 into pandas-dev:master May 27, 2021

TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021

TST: Check float format in object column (pandas-dev#35603) (pandas-d…

ab48402

…ev#41668)

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021

TST: Check float format in object column (pandas-dev#35603) (pandas-d…

e6ce470

…ev#41668)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST: Check float format in object column (#35603) #41668

TST: Check float format in object column (#35603) #41668

mdhsieh commented May 25, 2021

pep8speaks commented May 25, 2021 •

edited

Loading

mzeitlin11 commented May 26, 2021

mdhsieh commented May 26, 2021 •

edited

Loading

mzeitlin11 commented May 26, 2021

jreback left a comment

jreback May 27, 2021

mdhsieh May 27, 2021

jreback commented May 27, 2021

TST: Check float format in object column (#35603) #41668

TST: Check float format in object column (#35603) #41668

Conversation

mdhsieh commented May 25, 2021

pep8speaks commented May 25, 2021 • edited Loading

Comment last updated at 2021-05-27 17:30:45 UTC

mzeitlin11 commented May 26, 2021

mdhsieh commented May 26, 2021 • edited Loading

mzeitlin11 commented May 26, 2021

jreback left a comment

Choose a reason for hiding this comment

jreback May 27, 2021

Choose a reason for hiding this comment

mdhsieh May 27, 2021

Choose a reason for hiding this comment

jreback commented May 27, 2021

pep8speaks commented May 25, 2021 •

edited

Loading

mdhsieh commented May 26, 2021 •

edited

Loading