-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: standardize astype in EA subclasses #41652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @jbrockmendel, by changing the accepted types for astype we are changing the api for 3rd party EAs. probably needs a release note. (subclassed EA need to accept the same types as the base class) cc @Dr-Irv if any comments |
IMHO, I think you ought to first accept/merge in #41251 where I created overloads for I think there is a separate issue of how we should handle |
ill just revert the type annotation |
Mothballing since i cant replicate the failures locally. |
No description provided.