-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
GH41457 Upgrade Bootstrap to v5.0 #41651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update BS script tags in template Replace jumbotron with utilities Replace font-weight-bold with fw-bold Replace ml-auto with ms-auto Replace float-right with float-end Replace data-target with data-bs-target Replace data-toggle with data-bs-toggle Add CSS rules for <a>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @calvh, really nice. Lgtm, sorry for the delay.
Do you mind merging master? I think the CI should be green now.
Thank you @datapythonista! I am sorry this may be a dumb question, but do you mean I should merge with the latest master so that the CI will pass? If so, should I be doing merge (fast-forward) or rebase? |
Your branch was created two weeks ago, so your changes (the diff in this PR) are proposed on that old So, the idea is that you updated your branch, so it contains all the changes in master for the last two weeks. The CI should be then green, and also, if anything changed in master that affects this PR, we should have it in the diff and in the CI. In practice, that's simply Does it make sense? |
Merge to pass CI tests
@datapythonista I need some help, I merged master but some CI checks are still failing. Should I merge again with the latest master and try again? Thank you in advance. |
I can't check in detail now, but seems like all last PRs are red, so I guess something is broken in master. You'll have to wait until it's fixed, and thrn merge master again. |
Merge branch 'master' into 41457-upgrade-to-bootstrap5
@datapythonista thought I'd try again after merging with the latest master, but still no luck :( The error from one of the failing check occurs when running the bash script to create the conda environment
I wonder what I can do to fix this problem? |
Let's rerun and see, seems like conda servers are having problems recently. |
Thank you! All the tests passed except one. Looks like an issue with one of the |
GH PR pandas-dev#42413 Merge branch 'master' into 41457-upgrade-to-bootstrap5
@datapythonista all the tests passed. Thank you for your guidance and assistance! |
thanks @calvh |
Whats new:
Update BS script tags in template
Replace jumbotron with utilities
Replace font-weight-bold with fw-bold
Replace ml-auto with ms-auto
Replace float-right with float-end
Replace data-target with data-bs-target
Replace data-toggle with data-bs-toggle
Add CSS rules for