Skip to content

REF: share _mpl_repr #41627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2021
Merged

REF: share _mpl_repr #41627

merged 3 commits into from
May 25, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@simonjayhawkins simonjayhawkins added Index Related to the Index class or subclasses Refactor Internal refactoring of code labels May 23, 2021
simonjayhawkins
simonjayhawkins reviewed May 23, 2021
View reviewed changes
pandas/core/indexes/base.py Outdated
if isinstance(self.dtype, np.dtype) and self.dtype.kind != "M":
# Incompatible return value type (got "Union[ExtensionArray, ndarray]",
# expected "ndarray")
return self.values # type: ignore[return-value]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe cast here with comment. we have plenty of ignores to deal with without adding avoidable ones.

@jreback jreback added this to the 1.3 milestone May 24, 2021
@jreback jreback merged commit 140802a into pandas-dev:master May 25, 2021
@jbrockmendel jbrockmendel deleted the ref-mpl_repr branch May 25, 2021 13:59
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
@jbrockmendel @TLouf
REF: share _mpl_repr (pandas-dev#41627)
3eb9f1f
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
REF: share _mpl_repr (pandas-dev#41627)
9a1169c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Index Related to the Index class or subclasses Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @simonjayhawkins