REGR: CategoricalIndex(None) #41612
Merged
REGR: CategoricalIndex(None) #41612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
May 22, 2021
•
jbrockmendel
commented
- closes REGR: empty CatgoricalIndex constructor by passing no data (but passing categories) no longer working #38944
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
There was a problem hiding this comment.
Thanks @jbrockmendel needs a release note mentioning the deprecated behavior
| @@ -12,10 +12,14 @@ | |||
|
|
|||
| class TestCategoricalIndexConstructors: | |||
| def test_construction_disallows_scalar(self): | |||
| msg = "must be called with a collection of some kind" | |||
There was a problem hiding this comment.
we still want to test this message with a scalar passed
| @@ -12,10 +12,14 @@ | |||
|
|
|||
| class TestCategoricalIndexConstructors: | |||
| def test_construction_disallows_scalar(self): | |||
There was a problem hiding this comment.
need to change the name of this test
| @@ -12,10 +12,14 @@ | |||
|
|
|||
| class TestCategoricalIndexConstructors: | |||
| def test_construction_disallows_scalar(self): | |||
| msg = "must be called with a collection of some kind" | |||
| with pytest.raises(TypeError, match=msg): | |||
| with tm.assert_produces_warning(FutureWarning, match="without passing data"): | |||
| CategoricalIndex(categories=list("abcd"), ordered=False) | |||
There was a problem hiding this comment.
in #38614 some tests were changed. so I guess we should also be checking the result as well as that a warning is raised.
simonjayhawkins
added
Categorical
|
whatsnew note added, tests edited per suggestion |
|
Thanks @jbrockmendel |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.