REF: re-use sanitize_array in DataFrame._sanitize_columns #41611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Constructors
jreback
requested changes
May 25, 2021
jreback
approved these changes
May 26, 2021
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big partial-indexing test is split and has a non-trivial diff, but the only actual change is this line https://github.com/pandas-dev/pandas/compare/master...jbrockmendel:ref-sanitize_column?expand=1#diff-1723bf927d192314f9d8c4faa220e26b1c3b39c2fe3bb65d8c43966ec7e596e8R430 declaring that empty range is int-dtype-like instead of float-dtype-like, which i think we should call a bug.