[ArrowStringArray] TYP: add annotations to str.replace #41603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
commented
May 21, 2021
| @@ -1,12 +1,12 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| import codecs | |||
| from collections.abc import Callable # noqa: PDF001 | |||
There was a problem hiding this comment.
we should disable the custom pandas flake rule.
we should be importing Callable from collections.abc
https://docs.python.org/3/library/typing.html#callable
simonjayhawkins
commented
May 21, 2021
| from functools import wraps | ||
| import re | ||
| from typing import ( | ||
| TYPE_CHECKING, | ||
| Hashable, | ||
| Pattern, |
There was a problem hiding this comment.
we should not be using Pattern from typing.
https://www.python.org/dev/peps/pep-0585/
Importing those from typing is deprecated
simonjayhawkins
commented
May 21, 2021
| if regex and (is_compiled_re or len(pat) > 1 or flags or callable(repl)): | ||
| if not is_compiled_re: | ||
| if regex and ( | ||
| isinstance(pat, re.Pattern) or len(pat) > 1 or flags or callable(repl) |
There was a problem hiding this comment.
mypy cannot narrow types with is_compiled_re
simonjayhawkins
commented
May 21, 2021
| @@ -1374,6 +1378,9 @@ def replace(self, pat, repl, n=-1, case=None, flags=0, regex=None): | |||
| elif callable(repl): | |||
| raise ValueError("Cannot use a callable replacement when regex=False") | |||
|
|
|||
| if case is None: | |||
| case = True | |||
There was a problem hiding this comment.
changed so that case is not optional on array methods. all validation is done here.
simonjayhawkins
commented
May 21, 2021
| @@ -1,7 +1,8 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| import abc | |||
| from typing import Pattern | |||
| from collections.abc import Callable # noqa: PDF001 | |||
There was a problem hiding this comment.
another reason to disable the flake rule. abc is imported.
jreback
approved these changes
May 21, 2021
|
thanks @simonjayhawkins |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-cursor to #41590