-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPR: Timestamp.freq #41586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DEPR: Timestamp.freq #41586
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
07a131d
DEPR: Timestamp.freq
jbrockmendel 7f231e7
whatsnew
jbrockmendel a511ceb
update docs
jbrockmendel 8f4666d
typo fixup
jbrockmendel 913ed4b
Merge branch 'master' into depr-freq
jbrockmendel d222341
Merge branch 'master' into depr-freq
jbrockmendel 1cf43a8
Merge branch 'master' into depr-freq
jbrockmendel 2df27d2
Merge branch 'master' into depr-freq
simonjayhawkins e5edf28
Merge branch 'master' into depr-freq
jreback 1b8bc03
Merge branch 'master' into depr-freq
jbrockmendel 2f8e61b
Warn in fewer cases
jbrockmendel 7d9d524
Merge branch 'master' into depr-freq
jbrockmendel c0974c3
Merge branch 'depr-freq' of github.com:jbrockmendel/pandas into depr-…
jbrockmendel 4066dd2
Merge branch 'master' into depr-freq
jbrockmendel 3435954
Deprecated .freq, .freqstr lookups
jbrockmendel b93b6c1
Merge branch 'master' into depr-freq
jbrockmendel 069ae4c
mypy fixup
jbrockmendel e10a053
de-duplicate warnings
jbrockmendel 33df636
Merge branch 'master' into depr-freq
jbrockmendel e6f1c6b
filterwarning more precisely
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find the explanation of "for properties that use it .., when you have a
freq
, ..." very clear. Adding an actual example might clarify.First, I assume people who do
ts.is_month_start
(withts
being a Timestamp) don't necessarily know that they are relying on somefreq
.Also, the attributes are not going away, right? It's only the fastpath for computing it based on the freq that goes away? Are there actually cases that will change behaviour, or is it only performance? (and if only performance, that might not matter much for scalars, or maybe not worth warning about).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in principle we can know when this will change? (depending on the
freq
, we can know whether it can give different answers?)Could we warn only in those cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to warn in fewer cases. Still haven't updated the whatsnew note per the first comment here. suggestions on wording?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree here. i think we are simply deprecating freq. why do we need to even say anything about
is_month_start
for example?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bc the result of is_month_start is going to change in some cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One consequence of deprecating Timestamp.freq is that when having a timeseries with a freq, the following equivalency won't no longer always hold:
That's a bit unfortunate, I would say, and probably something we should explicitly document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for this as a followup documentation (but for 1.3)