DOC: fixup docstring of deprecate_nonkeyword_arguments #41577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martinwrudolf
commented
May 20, 2021
•
martinwrudolf
commented
- closes DOC: fixup docstring of deprecate_nonkeyword_arguments #41553
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
| @@ -267,7 +267,7 @@ def deprecate_nonkeyword_arguments( | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| version : str | |||
| version : str, optional | |||
There was a problem hiding this comment.
maybe could set None as the default
There was a problem hiding this comment.
True, but to be fair to them I didn't write that in the issue...IMO might as well merge as-in, the function itself could be given a default value later
simonjayhawkins
changed the title
|
Thanks @marty-rudolf |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.