-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Deprecate non-keyword arguments for Index.set_names. #41551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 11 commits into
pandas-dev:master
from
jmholzer:deprecate-nonkeyword-args-set_index
May 27, 2021
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f6e9ac1
ENH: Deprecate non-keyword arguments for Index.set_names.
jmholzer 17f5ff0
ENH: Deprecate non-keyword arguments for Index.set_names.
jmholzer ec20b8b
Merge branch 'master' into deprecate-nonkeyword-args-set_index
jreback a94c8ea
Merge remote-tracking branch 'upstream/master' into pr/jmholzer/41551
MarcoGorelli fc525c8
ENH: Deprecate non-keyword arguments for Index.set_names.
jmholzer 34b4f2f
merge
jmholzer aa2e644
ENH: Deprecate non-keyword arguments for Index.set_names.
jmholzer d38573b
merge
jmholzer 2d39763
Fix commented decorator.
jmholzer 1340963
Merge remote-tracking branch 'upstream/master' into pr/jmholzer-depre…
MarcoGorelli dc528b0
fixup
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as in the other PR, you'll probably need to define this for
MultiIndex
too (and remove@final
) so that the warning showsMultiIndex.set_names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this change in fc525c8.