Skip to content

[ArrowStringArray] REF: str.extract accessor method #41535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2021

Conversation

simonjayhawkins
Copy link
Member

perf neutral refactor, another step towards #41372

next steps
move code in str_extract into extract into StringMethods
combine code in _str_extract_noexpand and _str_extract_expand into a _str_extract method on the array

(not done here to keep diff simpler to review)

@simonjayhawkins simonjayhawkins added Refactor Internal refactoring of code Strings String extension data type and string data labels May 18, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 18, 2021
@jreback jreback merged commit 9652e97 into pandas-dev:master May 18, 2021
@simonjayhawkins simonjayhawkins deleted the extract-another-step branch May 18, 2021 14:12
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants