-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: add correct versions of numpy installs #4153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@y-p can u have a look-see? some notes:
anyway it seems to be working so lmk if u think i should change anything here's a travis build: |
Very strange about the LOCALE build refusing lxml, there shouldn't be any difference at all Adding a JOB_TAG envar to each job in travis.yml and using that to select the requirements file re numpy build deps, what packages specifically? I've had no problems building numpy All in all, If it works reliably, it's good enough. |
|
just a note to self: distribute 0.6.35 doesn't work with py3 |
The amount of pain and suffering python packaging inflicts on kind, honest devs.. note that latest pip stable use 0.6.34 I believe, and 0.6.35 is the minimum version required |
oh, they just released setuptools 0.8 final and pip 1.4rc3, perhaps |
Would changing the versions of pip and using setuptools require a rebuild of packages? if not, great, i'll try it, if so i'm going to stick with what works which is pip installing whatever version of distribute it does for py3 and 0.6.35 for py2 |
It should absolutley not make a difference. Obviously, you install packages from pypi without |
not sure what the lxml issue is and not worth tracking down for now...leaving the uninstall in |
This commit adds 5 requirements files: one for each Travis build. The corresponding sections in ci/install.sh are also removed in favor of these files. This allows pandas to have more fine-grained control over versions of hard and soft deps when using travis.
@y-p any last words before I merge (after passing)? |
yes: thanks for taking care of this! |
no problem! happy to grow a few gray hairs helping out pandas! quick recap of changes:
|
bombs away |
ENH: add correct versions of numpy installs
closes #4142.
should be able to finish up tomorrow, just need to put things on the server and
test