Skip to content

TYP: ExtensionArray delete() and searchsorted() #41513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Sep 6, 2021
Merged

TYP: ExtensionArray delete() and searchsorted() #41513

Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1bf4b5d
add typing for ExtensionArray.delete
Dr-Irv May 16, 2021
16bcc1a
typing searchsorted
Dr-Irv May 16, 2021
c0d426f
searchsorted typing updates throughout
Dr-Irv May 17, 2021
cce79a9
searchsorted typing updates throughout
Dr-Irv May 17, 2021
0a9cd7a
Merge remote-tracking branch 'upstream/master' into extdelete
Dr-Irv May 26, 2021
f37d215
remove NumpyArrayLike and fix arguments to index.searchsorted
Dr-Irv May 26, 2021
22b147a
Merge branch 'master' into extdelete
Dr-Irv May 31, 2021
065454f
validate_search_sorted fixup
Dr-Irv May 31, 2021
cde198e
fix to NDArrayBackedExtensionArray._validate_searchsorted_value
Dr-Irv Jun 1, 2021
b986eba
merge with master - just doc changes
Dr-Irv Jul 4, 2021
2d85ddb
merge with master - just doc changes
Dr-Irv Jul 4, 2021
493ab41
resolve conflicts
Dr-Irv Jul 4, 2021
f8f8b93
merge with master
Dr-Irv Jul 26, 2021
704abef
Merge remote-tracking branch 'upstream/master' into extdelete
Dr-Irv Jul 28, 2021
f8d4267
Merge remote-tracking branch 'upstream/master' into extdelete
Dr-Irv Jul 29, 2021
9c391a0
merge with master 0803
Dr-Irv Aug 3, 2021
4e60e04
Use numpy types in arguments and return types for searchsorted
Dr-Irv Aug 22, 2021
6a888ef
Small fix to validate_searchsorted_value
Dr-Irv Aug 22, 2021
2370384
add periods to docstrings
Dr-Irv Aug 23, 2021
42802ec
Merge remote-tracking branch 'upstream/master' into extdelete
Dr-Irv Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pandas/core/arrays/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,12 @@ def unique(self: ExtensionArrayT) -> ExtensionArrayT:
uniques = unique(self.astype(object))
return self._from_sequence(uniques, dtype=self.dtype)

def searchsorted(self, value, side="left", sorter=None):
def searchsorted(
self,
value: ArrayLike,
side: Literal["left", "right"] = "left",
sorter: ArrayLike | None = None,
):
"""
Find indices where elements should be inserted to maintain order.

Expand Down Expand Up @@ -1308,7 +1313,7 @@ def __hash__(self) -> int:
# ------------------------------------------------------------------------
# Non-Optimized Default Methods

def delete(self: ExtensionArrayT, loc) -> ExtensionArrayT:
def delete(self: ExtensionArrayT, loc: PositionalIndexer) -> ExtensionArrayT:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the 'public' base EA class. it was added in #39405. @jbrockmendel is this method public? Is it part of the EA interface? does it need a docstring?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch ill make a note to add a docstring

indexer = np.delete(np.arange(len(self)), loc)
return self.take(indexer)

Expand Down