Skip to content

TST/CLN: tests/strings/test_strings.py #41484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonjayhawkins
Copy link
Member

variable and test renaming, test splitting and parametrization of existing as a pre-cursor to further parametrization on dtype and moving.

@simonjayhawkins simonjayhawkins added Testing pandas testing functions or related to the test suite Strings String extension data type and string data Clean labels May 15, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 15, 2021
@jreback
Copy link
Contributor

jreback commented May 17, 2021

can you rebase. lgtm. ping on green.

@simonjayhawkins
Copy link
Member Author

green

@jreback jreback merged commit e6b2e29 into pandas-dev:master May 17, 2021
@jreback
Copy link
Contributor

jreback commented May 17, 2021

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the pandas/tests/strings/test_strings.py branch May 17, 2021 18:29
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Strings String extension data type and string data Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants