-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: unpin numpydoc, fix validation script #39688 #41456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fangchenli
commented
May 13, 2021
•
edited
Loading
edited
- closes DOC: doc-string validation broken #39688
The breaking change was from numpy/numpydoc#302. After modifying our script according to the new API. There is an AttributeError error:
|
@fangchenli is this actionable? |
except AttributeError: | ||
if not isinstance(self.obj, property): | ||
name = type(self.obj).__name__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't covered by any of the tests in scripts/validate_docstrings.py
- when could it happen?
except AttributeError: | ||
if not isinstance(self.obj, property): | ||
name = type(self.obj).__name__ | ||
if name is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likewise, none of the tests cover when name
is None
- when could that happen?
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
This PR has appeared to have gone stale. Feel free to reopen if you're still interested in working on this. |