Skip to content

WEB: Fix maintainers grid not displaying correctly (GH41438) #41447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2021
Merged

WEB: Fix maintainers grid not displaying correctly (GH41438) #41447

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
952d974
WEB: Remove row div from maintainers (GH41438)
calvh May 13, 2021
bb6308d
WEB: Fix maintainers grid display issue (GH41438)
calvh May 13, 2021
dd3859c
WEB: Remove if-else block in template (GH41438)
calvh May 14, 2021
2c0efc0
WEB: Add CSS selector to width rule (GH41438)
calvh May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 21 additions & 25 deletions web/pandas/about/team.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,27 @@ If you want to support pandas development, you can find information in the [dona

## Maintainers

<div class="row maintainers">
{% for row in maintainers.people | batch(6, "") %}
<div class="card-group maintainers">
{% for person in row %}
{% if person %}
<div class="card">
<img class="card-img-top" alt="" src="{{ person.avatar_url }}"/>
<div class="card-body">
<h6 class="card-title">
{% if person.blog %}
<a href="{{ person.blog }}">
{{ person.name or person.login }}
</a>
{% else %}
{{ person.name or person.login }}
{% endif %}
</h6>
<p class="card-text small"><a href="{{ person.html_url }}">{{ person.login }}</a></p>
</div>
</div>
{% else %}
<div class="card border-0"></div>
{% endif %}
{% endfor %}
</div>
<div class="card-group maintainers">
{% for person in maintainers.people %}
{% if person %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not wrong, this was the if used to discriminate the maintainers from the empty loop iterations generated by Jinja's batch, so not needed anymore. All the maintainers are people now ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks. My bad. I'll make the change on the inside as well.

<div class="card">
<img class="card-img-top" alt="" src="{{ person.avatar_url }}"/>
<div class="card-body">
<h6 class="card-title">
{% if person.blog %}
<a href="{{ person.blog }}">
{{ person.name or person.login }}
</a>
{% else %}
{{ person.name or person.login }}
{% endif %}
</h6>
<p class="card-text small"><a href="{{ person.html_url }}">{{ person.login }}</a></p>
</div>
</div>
{% else %}
<div class="card border-0"></div>
{% endif %}
{% endfor %}
</div>

Expand Down
6 changes: 6 additions & 0 deletions web/pandas/static/css/pandas.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ a.navbar-brand img {
div.card {
margin: 0 0 .2em .2em !important;
}
@media (min-width: 576px) {
div.card {
min-width: 10rem;
max-width: 10rem;
}
}
div.card .card-title {
font-weight: 500;
color: #130654;
Expand Down