-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Revert "Pin fastparquet to leq 0.5.0" #41443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Pin fastparquet to leq 0.5.0" #41443
Conversation
This reverts commit 5db1866.
I think we need 0.6.2, which isn't on conda-forge yet |
@phofl I can reproduce locally with 0.6.2
This is the error
|
Passes for me with 0.6.2 |
@martindurant Are you testing with master? (IIRC, this passes on 1.2.4 but fails on master). I can reproduce the failures on CI with master and fastparquet 0.6.2.
) |
No, I meant it passes against released pandas. So that means that something must have changed on the pandas side (also). If you happen to have the traceback for those failures, it may save me to the time to build a local main branch of pandas. It appears they all fail in the same way. |
thanks @lithomas1 and @martindurant for the patch! |
Thanks @martindurant. |
we have failures on 1.2.x. could backport this patch or backport #41370 instead. will start with trying this one. @meeseeksdev backport 1.2.x |
@lithomas1 This PR includes a patch, is a release note needed. I'm thinking best not to backport this if no release note. I'll backport #41370 first to see if can get ci to green, and maybe backport this after. |
closes #41366
Reverts #41370
Looks like fastparquet released a new version.