Skip to content

BUG: Series.str.extract with StringArray returning object dtype #41441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2021

Conversation

simonjayhawkins
Copy link
Member

test changes needed in #41372 revealed an issue with the current implementation. fixing for completeness and to add release note.

the dtype for an empty DataFrame from .str.get_dummies looks iffy so marking this as draft until further investigation.

@simonjayhawkins simonjayhawkins added Bug Strings String extension data type and string data labels May 12, 2021
@simonjayhawkins simonjayhawkins marked this pull request as ready for review May 13, 2021 07:04
@simonjayhawkins
Copy link
Member Author

the dtype for an empty DataFrame from .str.get_dummies looks iffy so marking this as draft until further investigation.

I can't recall why I originally changed that test in #41372 as there are no columns in the result so the dtype is irrelevant. have removed dtype on the .str.get_dummies test instead.

@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 13, 2021
@jreback
Copy link
Contributor

jreback commented May 14, 2021

looks good.

@jreback jreback merged commit 2e3d624 into pandas-dev:master May 14, 2021
@simonjayhawkins simonjayhawkins deleted the bugfix branch May 14, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants