-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Added regression test #41436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Added regression test #41436
Conversation
ShaharNaveh
commented
May 12, 2021
- closes BUG: DatetimeIndex gets converted to Index when operating on transpose of empty Dataframe #41382
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment, lgtm otherwise
@@ -10,6 +10,21 @@ | |||
|
|||
|
|||
class TestDatetimeIndex: | |||
def test_datetimeindex_transpose_empty_df(self): | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you post the link on purpose instead of only the reference like GH#xxx ? If yes, ok for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, on (some) terminal emulators, clicking on the link will auto open them.
Also when seeing the code via a browser, it's easier to copy it, and paste it in the URL bar, or highlighting the URL and right-clicking and select "open in a new tab". instead of: copying the number and then searching it in the issues tab.
TL;DR
This is for convenience, but not a deal breaker. I can have it as GH#XXXX
if it's a deal breaker:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinion, would prefer consistency, but if you have a strong optinion this is fine with me
Thanks for the test @ShaharNaveh |
…1436) Co-authored-by: ShaharNaveh <>