Skip to content

TST: Added regression test #41436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2021
Merged

Conversation

ShaharNaveh
Copy link
Member

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, lgtm otherwise

@@ -10,6 +10,21 @@


class TestDatetimeIndex:
def test_datetimeindex_transpose_empty_df(self):
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you post the link on purpose instead of only the reference like GH#xxx ? If yes, ok for me

Copy link
Member Author

@ShaharNaveh ShaharNaveh May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, on (some) terminal emulators, clicking on the link will auto open them.
Also when seeing the code via a browser, it's easier to copy it, and paste it in the URL bar, or highlighting the URL and right-clicking and select "open in a new tab". instead of: copying the number and then searching it in the issues tab.


TL;DR

This is for convenience, but not a deal breaker. I can have it as GH#XXXX if it's a deal breaker:)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion, would prefer consistency, but if you have a strong optinion this is fine with me

@datapythonista datapythonista added Testing pandas testing functions or related to the test suite Datetime Datetime data dtype labels May 13, 2021
@datapythonista datapythonista merged commit 3849fdb into pandas-dev:master May 13, 2021
@datapythonista
Copy link
Member

Thanks for the test @ShaharNaveh

@ShaharNaveh ShaharNaveh deleted the Fix-41382 branch May 19, 2021 12:11
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DatetimeIndex gets converted to Index when operating on transpose of empty Dataframe
3 participants