[ArrowStringArray] REF: extract/extractall column names #41417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Refactor
datapythonista
approved these changes
May 11, 2021
| return None | ||
|
|
||
|
|
||
| def _get_group_names(regex: Pattern) -> List[Hashable]: |
There was a problem hiding this comment.
This code has been working for a while, but wondering if it'd be useful to add a test for this function, seems trivial to add.
|
thanks @simonjayhawkins wouldn't object to moar tests |
|
the column naming already seems to be extensively tested in the extract/extractall tests with named groups, unnamed groups, some unnamed groups, one group, two groups etc. this is a precursor to #41372, same for extractall and then the dispatch to pyarrow kernels and perf opt of the object fallback. will add tests where there appear to be gaps. (but I don't think DataFrame column names or Index/Series names is one of those gaps) |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.