BUG: Rolling.__iter__ includes on index columns in the result #41405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
May 10, 2021
mroeschke
commented
- closes BUG: rolling window iterator with on should replace with the window index with the on column #40373
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
requested changes
May 10, 2021
|
|
|
Thanks for the explanation @jbrockmendel. Would you consider that a "bug" in BlockManager then? |
No. I think its overwhelmingly likely that the BM behavior will eventually be shared. |
|
Okay I'm going to punt on this until the AM & BM behavior aligns. Probably not worth having a work around for either case. |
|
ill move aligning these up my priority list and ping you when it happens |
|
No worries. This is just a nice to fix issue so no real priority. |
|
looks fine some ci/checks are failing (maybe just rebase)? |
|
Rebased and green. |
jreback
approved these changes
May 26, 2021
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
…-dev#41405) Co-authored-by: Jeff Reback <[email protected]>
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
…-dev#41405) Co-authored-by: Jeff Reback <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.